]> dgit.raspbian.org Git - gnome-shell.git/commit
popupMenu: Disconnect signal handlers when child section is destroyed
authorSebastian Keller <skeller@gnome.org>
Thu, 10 Sep 2026 22:13:24 +0000 (00:13 +0200)
committerFlorian Müllner <fmuellner@gnome.org>
Sun, 13 Sep 2026 21:56:15 +0000 (23:56 +0200)
commit17510c7dd59c8a96af90d419d5bb5d29c25a8e43
treeebd95222a9d77a8d40e61be60987424dd19fa489
parentd710f00a56522a72b9b27e3c0feca3b70dee71cf
popupMenu: Disconnect signal handlers when child section is destroyed

Neither `PopupMenuBase` nor `PopupMenuSection` are destroyable, thus the
signal connection needs to be manually disconnected to avoid leaking
both via the respective signal trackers.

This disconnects the connections in both directions when the child
`PopupMenuSection` is destroyed, which handles both cases the section
being destroyed, but also the parent menu being destroyed, because that
also triggers the destruction of all children.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/4398>
(cherry picked from commit 2a923660bc1212cc0249dbb8833d28a708f089c0)
js/ui/popupMenu.js